New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add Aurelia v1 samples (complete) #133
Conversation
Add event-click, dom-ref and conditional. Update readme.
Verified using codesandbox with typescript. https://codesandbox.io/s/aurelia-typescript-sandbox-forked-rlniej
Not easy to test. The component is not really unmounted in this case.
cs: add missing enter in 4-1.
Also, fix minor issue in 4-3-slot
Refectoring could be beneficial for quality of the code. Todo added in Readme.
Links can be set up using pushState, or using hash bashed routing. The later is used in this example, with link to the documentation.
Update readme with finished matschik#7 and 100% Aurelia1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution !
- Component names in general are not the same as the other frameworks
- How the ".ts" file is related to ".html" and ".css" file exactly ? How is it linked ?
I will continue the review after these fixes.
I will update all to use the same names as the other frameworks use.
From the Aurelia documentation (link): "In order to render, we need to create a view for the app component. This introduces the next convention of Aurelia. To create a view for any class, simply create an HTML file with the same name as the ES Next module but change the file extension to .html. Inside that view, you can place an HTML 5 template with data binding expressions declaring how the view should render an instance of the class." Styling I will change. It is not connected into the model it seems. We don't use separate files at all, so I should have checked that myself, sorry for that. Link: https://aurelia.io/docs/cli/cli-bundler/basics#styling-your-application |
* consistent filenames compared to other frameworks * improved code style (applied not just for the templates, but the other Aurelia files as well. Used VSCode "Format code" command on all files)
* Since scss is not default, use the standard css files instead. * Apply filesorter to show the app-files first
Resolves: #101
After reading #101, I decided this would be my xmas holiday project.
The code was initially based on the v1.x version, but is now updated with the v2.0.0 branch.